On Thu, Oct 31, 2024 at 08:09:00PM -0700, Qiang Yu wrote: > The SC8280XP PCIe devicetree nodes do not specify an 'iommu-map' so the > config_sid() callback is effectively a no-op. Hence introduce a new ops Would have been good to say something about why there are no 'iommu-map' properties on sc8280xp (e.g. since it uses an SMMUv3) as Bjorn suggested. > struct, namely ops_1_21_0 which is same as ops_1_9_0 except that it > doesn't have config_sid() callback to clean it up. > > Signed-off-by: Qiang Yu <quic_qianyu@xxxxxxxxxxx> > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> I see that this patch has been picked up now. The above is already much better and I guess this is good enough for now: Reviewed-by: Johan Hovold <johan+linaro@xxxxxxxxxx>