On Tue, Oct 29, 2024 at 12:27:41PM +0100, Niklas Schnelle wrote: > For what it's worth on s390 I think the previous proposal of having the > attribute on the pci_bus would have been better in principle. On s390 > the PCI bus probing is done by firmware and Linux doesn't see a pci_dev > for bridges but we do create struct pci_bus for example for a PF and > its child VFs. > > Then again we can't really do a reset on this level, other than > manually going through the PCI functions and resetting them one by one. > In fact we may see PCI functions on their own bus while another Linux > instance (LPAR) sees other functions from that bus. So yeah, I guess > it's fair not to have this attribute but still wanted to offer these > thoughts. This attribute uses the pci_dev bridge control register. If you don't have the bridge device, I don't think this would be useful, so I guess you'd have to fallback to resetting individual functions. It seems people can navigate /sys/bus/pci/devices/ easier than finding a pci_bus under /sys/devices/, though, so that's a plus for pci_dev.