On Thu, Jun 21, 2012 at 2:24 PM, Myron Stowe <myron.stowe@xxxxxxxxxx> wrote:
> The PCI subsystem's final fixups are executed once during boot, after the
> pci-device is found. As long as the system does not support hot-plug,
> specifying __init is fine.
>
> With hot-plug, either physically based hot-plug events or pseudo hot-plug
> events such as "echo 1 > /sys/bus/pci/rescan", it is possible to remove a
> PCI bus during run time and have it rediscovered which will require the
> call of the fixups again in order for the device to function properly.
>
> This patch prepares specific quirk(s) for use with hot-plug events.
>
> Signed-off-by: Myron Stowe <myron.stowe@xxxxxxxxxx>
> ---
>
> arch/arm/mach-iop32x/n2100.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-iop32x/n2100.c b/arch/arm/mach-iop32x/n2100.c
> index 5a7ae91..04c4110 100644
> --- a/arch/arm/mach-iop32x/n2100.c
> +++ b/arch/arm/mach-iop32x/n2100.c
> @@ -126,7 +126,7 @@ static struct hw_pci n2100_pci __initdata = {
> * the ->broken_parity_status flag for both ports so that the r8169
> * driver knows it should ignore error interrupts.
> */
> -static void n2100_fixup_r8169(struct pci_dev *dev)
> +static void __devinit n2100_fixup_r8169(struct pci_dev *dev)
These actually move functions from normal text to __devinit, not from
__init to __devinit.
That should be safe for most quirks (although enable, suspend, resume,
and resume_early quirks can be called after we free initmem, even if
we have CONFIG_HOTPLUG=n), but given the discussion about whether we
should even bother with __devinit any more, I think I'll hold off on
these for now. If we were to get rid of __devinit, these would all
have to revert to being normal text.
> {
> if (dev->bus->number == 0 &&
> (dev->devfn == PCI_DEVFN(1, 0) ||
>
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
