Hi Jonathan, I added comments below. On 10/30/2024 10:45 AM, Jonathan Cameron wrote: > On Fri, 25 Oct 2024 16:02:59 -0500 > Terry Bowman <terry.bowman@xxxxxxx> wrote: > > Typo in title. Shouldn't be plural ports. I'll remove the plural. Thanks. >> CXL PCIe port protocol error support will be added in the future. This >> requires searching for a CXL PCIe port device in the CXL topology as >> provided by find_cxl_port(). But, find_cxl_port() is defined static >> and as a result is not callable outside of this source file. >> >> Update the find_cxl_port() declaration to be non-static. >> >> Signed-off-by: Terry Bowman <terry.bowman@xxxxxxx> > Doesn't hugely matter but I'd do this later in the series as it's > not used until patch 12 (I think) and by then reviewers may have forgotten what > it is for. > > Fine otherwise, > > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> Thanks. I will move this patch to later. Regards, Terry
