On Mon, Jun 25, 2012 at 6:26 PM, Kaneshige, Kenji <kaneshige.kenji@xxxxxxxxxxxxxx> wrote: >> -----Original Message----- >> From: linux-pci-owner@xxxxxxxxxxxxxxx >> [mailto:linux-pci-owner@xxxxxxxxxxxxxxx] On Behalf Of Yinghai Lu >> Sent: Saturday, June 23, 2012 4:42 PM >> To: Bjorn Helgaas >> Cc: linux-pci@xxxxxxxxxxxxxxx; Yinghai Lu >> Subject: [PATCH 2/5] pciehp: Don't enable presence notification while >> surprise removal is not supported. >> >> If surprise removal is not supported, that event get dropped later. >> So there is no point to enable that. > > Presence changed event is currently just for printing a kernel message when > surprise removal is not supported, and I think the message is not so important. > So I agree this change. > > Acked-by: Kenji Kaneshige <kaneshige.kenji@xxxxxxxxxxxxxx> Thanks > >> >> Also some sick chipset have those bit flip around when the card is not >> present. >> and make log full of useless warning. > > Is there any other way to avoid this issue other than disabling presence > changed notification? If we need enabling presence changed event in the > future, this will happen again. I'm worrying about this. could be fixed from HW change and CPLD change. Thanks Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
