On Thu, Oct 24, 2024 at 10:21:17AM -0600, Logan Gunthorpe wrote: > On 2024-10-23 23:50, Kasireddy, Vivek wrote: > >> I'd echo many of Bjorn's concerns. In addition, I think the name of the > >> pci_devs_are_p2pdma_compatible() isn't quite right. Specifically this is > >> dealing with PCI functions within a single device that are known to > >> allow P2P traffic. So I think the name should probably reflect that. > > > > Would pci_devfns_support_p2pdma() be a more appropriate name? > > That sounds better to me, thanks. This sounds similar to what's done in pci_dev_specific_acs_enabled(). Could this problem be solved by adding more device-specific quirks there? Bjorn