On Tue, Oct 22, 2024 at 03:48:51PM -0700, Keith Busch wrote: > From: Keith Busch <kbusch@xxxxxxxxxx> > > There's only one user of this, and it's internal, so no need to export > it. > > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > Reviewed-by: Davidlohr Bueso <dave@xxxxxxxxxxxx> > Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx> > Signed-off-by: Keith Busch <kbusch@xxxxxxxxxx> > --- > drivers/pci/bus.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/pci/bus.c b/drivers/pci/bus.c > index 9c552396241e0..d015d5821cefc 100644 > --- a/drivers/pci/bus.c > +++ b/drivers/pci/bus.c > @@ -445,7 +445,6 @@ void pci_walk_bus_locked(struct pci_bus *top, int (*cb)(struct pci_dev *, void * > > __pci_walk_bus(top, cb, userdata); > } > -EXPORT_SYMBOL_GPL(pci_walk_bus_locked); I think we could also move the declaration from include/linux/pci.h to drivers/pci/pci.h, right? I guess there's some argument for keeping it in include/linux/pci.h next to the pci_walk_bus() declaration, but I certainly don't want to encourage more use of either one, especially outside the PCI core.
