Hi Dan, On 10/21/24 21:17, Dan Williams wrote: > Terry Bowman wrote: >> CXL port error handling will be updated in future and will use >> logic to determine if an error requires CXL or PCIe processing. >> Internal errors are one indicator to identify an error is a CXL >> protocol error. > > I expect it would better to fold this into the patch that makes use of > the is_internal_error() outside of the CONFIG_PCIEAER_CXL case. > > With this patch in isolation it is not clear that a kernel that sets > CONFIG_PCIEAER_CXL=n should distinguish PCIe internal errors from CXL > errors. > > The real problem seems to be that CONFIG_PCIEAER_CXL depends on CXL_PCI. > I.e. is_internal_error() only matters for the CXL case, and the CXL > handling is moving more into the core and dropping its CXL_PCI > dependency. I will merge the patch as you described. Regards, Terry
