Hi Bjorn, I added a response below. On 10/18/24 18:22, Bjorn Helgaas wrote: > On Tue, Oct 08, 2024 at 05:16:42PM -0500, Terry Bowman wrote: >> This is a continuation of the CXL port error handling RFC from earlier.[1] >> The RFC resulted in the decision to add CXL PCIe port error handling to >> the existing RCH downstream port handling. This patchset adds the CXL PCIe >> port handling and logging. >> >> The first 7 patches update the existing AER service driver to support CXL >> PCIe port protocol error handling and reporting. This includes AER service >> driver changes for adding correctable and uncorrectable error support, CXL >> specific recovery handling, and addition of CXL driver callback handlers. >> >> The following 8 patches address CXL driver support for CXL PCIe port >> protocol errors. This includes the following changes to the CXL drivers: >> mapping CXL port and downstream port RAS registers, interface updates for >> common RCH and VH, adding port specific error handlers, and protocol error >> logging. > > Looks like all my comments at > https://lore.kernel.org/r/20241010190726.GA570880@bhelgaas still > apply. > > URL broken across lines, distracting timestamps, patch subjects, > no clue about the base commit. I added changes for code reuse in pcie_do_recovery() as recommended. I am finishing testing now and will have v2 upstreamed shortly. Regards, Terry
