Re: [PATCH 0/6] Coverity and trivial fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 20, 2012 at 6:16 PM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote:
> These fix a few issues reported by the Coverity checker and a trivial
> style issue (__weak).
>
> Only two should have interesting effects:
>
>  - The OBFF/LTR enable functions should panic without this fix, so
>    I don't think they've ever been tested.
>
>  - The P2P bridge I/O window fix doesn't affect x86, which never uses
>    32-bit I/O decoding.  But other architectures might notice because
>    we incorrectly sign-extended I/O port addresses of 0x80000000 and
>    above.
>
> I'll wait for comments before putting them in "next" (targeted for 3.6).
> ---
>
> Bjorn Helgaas (6):
>      PCI: use __weak consistently
>      PCI: fix upstream P2P bridge checks when enabling OBFF and LTR
>      PCI: fix P2P bridge I/O port window sign extension
>      PCI: shpchp: remove dead code
>      PCI: acpiphp: check whether _ADR evaluation succeeded
>      PCI: remove useless pcix_set_mmrbc() dev->bus check
>
>
>  drivers/pci/hotplug/acpiphp_glue.c |   13 +++++++++----
>  drivers/pci/hotplug/shpchp_ctrl.c  |    3 ---
>  drivers/pci/pci-sysfs.c            |    2 +-
>  drivers/pci/pci.c                  |   15 +++++++--------
>  drivers/pci/probe.c                |   18 ++++++++++--------
>  5 files changed, 27 insertions(+), 24 deletions(-)

I applied these to my "next" branch.  Let me know if you see any issues.
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux