Hi Manivannan, On Sat, 12 Oct 2024 at 13:32, Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> wrote: > > On Sat, Oct 12, 2024 at 12:55:38PM +0530, Anand Moon wrote: > > Hi Manivannan, > > > > Thanks for your review comments. > > > > On Sat, 12 Oct 2024 at 11:50, Manivannan Sadhasivam > > <manivannan.sadhasivam@xxxxxxxxxx> wrote: > > > > > > On Sat, Oct 12, 2024 at 10:36:05AM +0530, Anand Moon wrote: > > > > Refactor the rockchip_pcie_disable_clocks function to accept a > > > > struct rockchip_pcie pointer instead of a void pointer. This change > > > > improves type safety and code readability by explicitly specifying > > > > the expected data type. > > > > > > > > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> > > > > Signed-off-by: Anand Moon <linux.amoon@xxxxxxxxx> > > > > --- > > > > v7: None > > > > v6: Fix the subject, add the missing () in the function name. > > > > > > Did you remove it in v7? Please don't do that, it just increases the burden on > > > reviewers. > > > > > > - Mani > > Earlier, it was reported that function () should be used in the function name. > > Hmm. Why can't you do the same for the description also? > Ok, I missed this point. > - Mani > > -- > மணிவண்ணன் சதாசிவம் Thanks -Anand
