On Fri, Oct 11, 2024 at 09:21:29PM +0900, Damien Le Moal wrote:
> On 10/11/24 21:07, Niklas Cassel wrote:
> >> +int pci_epc_mem_map(struct pci_epc *epc, u8 func_no, u8 vfunc_no,
> >> + u64 pci_addr, size_t pci_size, struct pci_epc_map *map)
> >> +{
> >> + int ret;
> >> +
> >> + if (!pci_epc_function_is_valid(epc, func_no, vfunc_no))
> >> + return -EINVAL;
> >> +
> >> + if (!pci_size || !map)
> >> + return -EINVAL;
> >> +
> >> + ret = pci_epc_get_mem_map(epc, func_no, vfunc_no,
> >> + pci_addr, pci_size, map);
> >> + if (ret)
> >> + return ret;
> >> +
> >> + map->virt_base = pci_epc_mem_alloc_addr(epc, &map->phys_base,
> >> + map->map_size);
> >> + if (!map->virt_base)
> >> + return -ENOMEM;
> >> +
> >> + map->phys_addr = map->phys_base + map->map_ofst;
> >> + map->virt_addr = map->virt_base + map->map_ofst;
> >> +
> >> + ret = pci_epc_map_addr(epc, func_no, vfunc_no, map->phys_base,
> >> + map->map_pci_addr, map->map_size);
> >> + if (ret) {
> >> + pci_epc_mem_free_addr(epc, map->phys_base, map->virt_base,
> >> + map->map_size);
> >> + map->virt_base = 0;
> >
> > As reported by the kernel test robot on both v3 and v4, this should be:
> > map->virt_base = NULL;
> > otherwise you introduce a new sparse warning.
>
> Oops. Missed that... OK, sending v6 with this removed as that is not necessary
> anyway.
>
Please incorporate this in v6.
- Mani
--
மணிவண்ணன் சதாசிவம்
