Hi Manivannan, Thanks for your review comments. On Sat, 12 Oct 2024 at 11:38, Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> wrote: > > On Sat, Oct 12, 2024 at 10:36:03AM +0530, Anand Moon wrote: > > Refactor the clock handling in the Rockchip PCIe driver, > > introducing a more robust and efficient method for enabling and > > disabling clocks using clk_bulk*() API. Using the clk_bulk APIs, > > I think I mentioned earlier to use impreative tone in commit messages. > I missed your point. > > the clock handling for the core clocks becomes much simpler. Will improve this. my focus is just I don't break the functionally. > > > > Could you please elaborate how? i.e., devm_clk_bulk_get_all() allows the driver > to get all clocks defined in the DT thereby removing the hardcoded clock names > in the driver. > Ok, I will elaborate on this in the next version. > > - Replace devm_clk_get() with devm_clk_bulk_get_all(). > > - Replace clk_prepare_enable() with clk_bulk_prepare_enable(). > > - Replace clk_disable_unprepare() with clk_bulk_disable_unprepare(). > > > > Signed-off-by: Anand Moon <linux.amoon@xxxxxxxxx> > > With above changes, > > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> > > - Mani I will try to improve the next version. Thanks -Anand
