On Thu, 10 Oct 2024 12:38:08 +0200 Lukas Wunner <lukas@xxxxxxxxx> wrote: > On Fri, Oct 04, 2024 at 12:28:28PM -0400, Gregory Price wrote: > > Polling on the PCI DOE Busy Bit for (at max) one PCI DOE timeout > > interval (1 second), resolves this issues cleanly. > > Nit: s/issues/issue/ > > > Subsqeuent code in doe_statemachine_work and abort paths also wait > > Nit: s/Subsqeuent/Subsequent/ > > > --- a/drivers/pci/doe.c > > +++ b/drivers/pci/doe.c > > @@ -149,14 +149,26 @@ static int pci_doe_send_req(struct pci_doe_mb *doe_mb, > > size_t length, remainder; > > u32 val; > > int i; > > + unsigned long timeout_jiffies; > > Nit: Reverse Christmas tree. > > With that addressed, > Reviewed-by: Lukas Wunner <lukas@xxxxxxxxx> > Looks good to me with Lukas' nits tidied up. Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
