Hi Anand, kernel test robot noticed the following build warnings: url: https://github.com/intel-lab-lkp/linux/commits/Anand-Moon/PCI-rockchip-Simplify-clock-handling-by-using-clk_bulk-function/20241007-022714 base: 8f602276d3902642fdc3429b548d73c745446601 patch link: https://lore.kernel.org/r/20241006182445.3713-2-linux.amoon%40gmail.com patch subject: [PATCH v6 RESET 1/3] PCI: rockchip: Simplify clock handling by using clk_bulk*() function config: loongarch-randconfig-r071-20241009 (https://download.01.org/0day-ci/archive/20241010/202410100015.9W01OqrR-lkp@xxxxxxxxx/config) compiler: loongarch64-linux-gcc (GCC) 14.1.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> | Closes: https://lore.kernel.org/r/202410100015.9W01OqrR-lkp@xxxxxxxxx/ smatch warnings: drivers/pci/controller/pcie-rockchip.c:132 rockchip_pcie_parse_dt() warn: passing zero to 'dev_err_probe' vim +/dev_err_probe +132 drivers/pci/controller/pcie-rockchip.c 964bac9455bee7 drivers/pci/host/pcie-rockchip.c Shawn Lin 2018-05-09 122 if (rockchip->is_rc) { 58adbfb3ebec46 drivers/pci/controller/pcie-rockchip.c Chen-Yu Tsai 2021-01-22 123 rockchip->ep_gpio = devm_gpiod_get_optional(dev, "ep", 840b7a5edf88fe drivers/pci/controller/pcie-rockchip.c Manivannan Sadhasivam 2024-04-16 124 GPIOD_OUT_LOW); 58adbfb3ebec46 drivers/pci/controller/pcie-rockchip.c Chen-Yu Tsai 2021-01-22 125 if (IS_ERR(rockchip->ep_gpio)) 58adbfb3ebec46 drivers/pci/controller/pcie-rockchip.c Chen-Yu Tsai 2021-01-22 126 return dev_err_probe(dev, PTR_ERR(rockchip->ep_gpio), 58adbfb3ebec46 drivers/pci/controller/pcie-rockchip.c Chen-Yu Tsai 2021-01-22 127 "failed to get ep GPIO\n"); e77f847df54c6b drivers/pci/host/pcie-rockchip.c Shawn Lin 2016-09-03 128 } e77f847df54c6b drivers/pci/host/pcie-rockchip.c Shawn Lin 2016-09-03 129 9a8ff91a0ee96b drivers/pci/controller/pcie-rockchip.c Anand Moon 2024-10-06 130 rockchip->num_clks = devm_clk_bulk_get_all(dev, &rockchip->clks); 9a8ff91a0ee96b drivers/pci/controller/pcie-rockchip.c Anand Moon 2024-10-06 131 if (rockchip->num_clks < 0) 9a8ff91a0ee96b drivers/pci/controller/pcie-rockchip.c Anand Moon 2024-10-06 @132 return dev_err_probe(dev, err, "failed to get clocks\n"); ^^^ Was intended to be rockchip->num_clks. 4816c4c7b82b55 drivers/pci/host/pcie-rockchip.c Shawn Lin 2016-12-07 133 964bac9455bee7 drivers/pci/host/pcie-rockchip.c Shawn Lin 2018-05-09 134 return 0; 4816c4c7b82b55 drivers/pci/host/pcie-rockchip.c Shawn Lin 2016-12-07 135 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki