On Mon, Oct 07, 2024 at 04:22:17PM +0900, Damien Le Moal wrote: > On 10/7/24 16:00, Krzysztof Kozlowski wrote: > >> I do not see reset-gpios being defined in the bindings (common, host and ep). > >> resets and reset-names are defined though but these have nothing to do with > >> #PERST control. > > > > Bindings for all PCI devices. See pci-bus-common.yaml > > Got it. But in this case, since ep-gpios is already defined for the RC host mode > controller, isn't it simpler to simply move that property to > rockchip,rk3399-pcie-common.yaml ? > > I can of course instead re-use the reset-gpios property for the endpoint mode, > but that will need a bit more code in the driver. > > Which way do you recommend ? > Please use 'reset-gpios' instead. Using 'ep-gpios' for the endpoint controller doesn't convey the actual use. - Mani -- மணிவண்ணன் சதாசிவம்
