On 10/6/24 20:48, Niklas Cassel wrote: > On Fri, Oct 04, 2024 at 10:47:01PM +0900, Damien Le Moal wrote: >> On 10/4/24 21:11, Niklas Cassel wrote: > > (snip) > >>> I think that you need to also include the patch that implements map_align() >>> for rk3399 in this series (without any other rk3399 patches), such that the >>> API actually makes sense. >> >> This is coming in a followup series. Note that the Cadence controller also look >> suspiciously similar to the rk3399, so it may need the same treatment. > > I strongly think that you should continue to include patch: > "PCI: rockchip-ep: Implement the map_align endpoint controller operation" > (that was part of your V2) in this series. I would rather not because this patch needs a prep patch that fixes the currently broken rockchip_pcie_prog_ep_ob_atu() function. So I will post this patch as part of a series for the rk3399 today. -- Damien Le Moal Western Digital Research
