On 10/4/24 20:47, Niklas Cassel wrote: > Naming is one of the hardest problems in computer science :) Yep. > Perhaps: > s/pci_epc_mem_map()/pci_epc_mem_alloc_map()/ > s/pci_epc_mem_unmap()/pci_epc_mem_free_unmap()/ > > is slightly more clear that this both allocates and maps. Sure, but I consider the allocation an implementation detail of the function. And I really prefer the shorter function names :) > Regardless: > Reviewed-by: Niklas Cassel <cassel@xxxxxxxxxx> Thanks. -- Damien Le Moal Western Digital Research
