On Fri, Sep 27, 2024 at 01:47:44PM +0530, Anand Moon wrote:
> On Mon, 2 Sept 2024 at 00:03, Anand Moon <linux.amoon@xxxxxxxxx> wrote:
> >
> > Refactor the clock handling in the Rockchip PCIe driver,
> > introducing a more robust and efficient method for enabling and
> > disabling clocks using clk_bulk*() API. Using the clk_bulk APIs,
> > the clock handling for the core clocks becomes much simpler.
> >
> > Signed-off-by: Anand Moon <linux.amoon@xxxxxxxxx>
>
> Do you have any review comments on this series?
Looks like nice work, thanks. Minor tips below. We'll start applying
PCI patches to v6.13-rc1 after it is tagged. It looks like these will
apply cleanly, so no rebasing needed.
- It would be helpful if you can add a cover letter (0/n), which is
a good place for the overall diffstat and series-level changelog.
- This v5 series adds drivers/phy patches, which are also related to
rockchip, but will be handled by a different maintainer, so best
to send them as separate series (and of course send the phy
patches to the right maintainer, linux-phy, etc).
- "b4 am -o/tmp/ 20240901183221.240361-2-linux.amoon@xxxxxxxxx"
complains about something, I dunno how to fix:
Checking attestation on all messages, may take a moment...
---
✗ [PATCH v5 1/6] PCI: rockchip: Simplify clock handling by using clk_bulk*() function
✗ [PATCH v5 2/6] PCI: rockchip: Simplify reset control handling by using reset_control_bulk*() function
✗ [PATCH v5 3/6] PCI: rockchip: Refactor rockchip_pcie_disable_clocks function signature
✗ [PATCH v5 4/6] phy: rockchip-pcie: Simplify error handling with dev_err_probe()
✗ [PATCH v5 5/6] phy: rockchip-pcie: Change to use devm_clk_get_enabled() helper
✗ [PATCH v5 6/6] phy: rockchip-pcie: Use regmap_read_poll_timeout for PCIe reference clk PLL status
---
✗ BADSIG: DKIM/gmail.com
- In 3/6 and 6/6 commit logs, add parens after function names as
you did elsewhere.
- Super nit: In 5/6, s/Change to use/Use/. Every patch is a change,
so "Change to" doesn't add any information.
Bjorn
