On 6/19/2012 4:07 PM, Yinghai Lu wrote: > On Tue, Jun 19, 2012 at 12:50 PM, Geert Uytterhoeven > <geert@xxxxxxxxxxxxxx> wrote: >> Hi Chris, >> >> On Sat, Apr 7, 2012 at 11:10 PM, Chris Metcalf <cmetcalf@xxxxxxxxxx> wrote: >>> This change implements PCIe root complex support for tilegx using >>> the kernel support layer for accessing the TRIO hardware shim. >>> --- /dev/null >>> +++ b/arch/tile/kernel/pci_gx.c >>> + bus = pci_scan_bus(0, controller->ops, controller); >>> + controller->root_bus = bus; >>> + controller->last_busno = bus->subordinate; >> As of commit 3527ed81ca01bbaf09df952e68528377a9cd092f >> ("PCI: remove secondary/subordinate in struct pci_bus") in linux-next, the >> "subordinate" field no longer exists: >> >> http://kisskb.ellerman.id.au/kisskb/buildresult/6546355/ >> arch/tile/kernel/pci_gx.c:852:31: error: 'struct pci_bus' has no >> member named 'subordinate' >> make[3]: *** [arch/tile/kernel/pci_gx.o] Error 1 > could changed to be > contoller->last_busno = bus->busn.end; Yes, I saw this build failure in the linux-next logs, but I'm not sure what to do about it. I can't adopt Yinghai's solution in my tree since my tree is based off of Linus's tree which doesn't have "bus->busn". I suppose I could publish two trees to linux-next, one based off of Bjorn's "pci" tree (I assume) and one with all the non-PCI arch/tile stuff (my current linux-next tree). I admit I was lazily assuming I would just fix this once the trees collided during the 3.6 merge window :-) -- Chris Metcalf, Tilera Corp. http://www.tilera.com -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html