RE: [PATCH v1 1/9] dt-bindings: imx6q-pcie: Add ref clock for i.MX95 PCIe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: Conor Dooley <conor@xxxxxxxxxx>
> Sent: 2024年9月25日 0:04
> To: Frank Li <frank.li@xxxxxxx>
> Cc: Hongxing Zhu <hongxing.zhu@xxxxxxx>; l.stach@xxxxxxxxxxxxxx;
> kwilczynski@xxxxxxxxxx; bhelgaas@xxxxxxxxxx; lpieralisi@xxxxxxxxxx;
> robh+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx; shawnguo@xxxxxxxxxx;
> krzysztof.kozlowski+dt@xxxxxxxxxx; festevam@xxxxxxxxx;
> s.hauer@xxxxxxxxxxxxxx; linux-pci@xxxxxxxxxxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx; imx@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v1 1/9] dt-bindings: imx6q-pcie: Add ref clock for i.MX95
> PCIe
> 
> On Tue, Sep 24, 2024 at 11:23:06AM -0400, Frank Li wrote:
> > On Tue, Sep 24, 2024 at 11:08:20AM +0100, Conor Dooley wrote:
> > > On Tue, Sep 24, 2024 at 11:27:36AM +0800, Richard Zhu wrote:
> > > > Add one ref clock for i.MX95 PCIe. Increase clocks' maxItems to 5
> > > > and keep the same restriction with other compatible string.
> > > >
> > > > Signed-off-by: Richard Zhu <hongxing.zhu@xxxxxxx>
> > >
> > > It'd be really good to mention why this clock is appearing now, when
> > > it did not before. You're just explaining what you've done, which
> > > can be seen in the diff, but not why you did it.
> >
> > Previous reference clock of i.MX95 is on when system boot to kernel.
> > But boot firmware change the behavor, so it is off when boot. So it
> > need be turn on when it use. Also it need be turn off/on when suspend and
> resume.
> > Previous miss this feature.
> 
> Please put this in the commit message Richard.
Hi Conor:
Thanks for your comments.
Would add these information in the commit message later.

Best Regards
Richard Zhu
> 
> Thanks,
> Conor.




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux