The CPU address and PCI address are the same in most system. But in some systems such as i.MX8QXP, they are different. Previously, we used the cpu_addr_fixup() hook function to handle address translation. However, the device tree can use the common 'ranges' property to indicate how CPU and PCI addresses are translated. Replace the fields 'phys_base' and 'addr_size' in struct dw_pcie_ep with struct of_pci_range 'range'. The of_pci_range already includes cpu_addr and size information. Prepare to add 'ranges' support. Signed-off-by: Frank Li <Frank.Li@xxxxxxx> --- drivers/pci/controller/dwc/pcie-artpec6.c | 2 +- drivers/pci/controller/dwc/pcie-designware-ep.c | 6 +++--- drivers/pci/controller/dwc/pcie-designware.h | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-artpec6.c b/drivers/pci/controller/dwc/pcie-artpec6.c index f8e7283dacd47..f93d3c7a980c8 100644 --- a/drivers/pci/controller/dwc/pcie-artpec6.c +++ b/drivers/pci/controller/dwc/pcie-artpec6.c @@ -104,7 +104,7 @@ static u64 artpec6_pcie_cpu_addr_fixup(struct dw_pcie *pci, u64 cpu_addr) case DW_PCIE_RC_TYPE: return cpu_addr - pp->cfg0_base; case DW_PCIE_EP_TYPE: - return cpu_addr - ep->phys_base; + return cpu_addr - ep->range.cpu_addr; default: dev_err(pci->dev, "UNKNOWN device type\n"); } diff --git a/drivers/pci/controller/dwc/pcie-designware-ep.c b/drivers/pci/controller/dwc/pcie-designware-ep.c index 43ba5c6738df1..feac1a435f764 100644 --- a/drivers/pci/controller/dwc/pcie-designware-ep.c +++ b/drivers/pci/controller/dwc/pcie-designware-ep.c @@ -872,8 +872,8 @@ int dw_pcie_ep_init(struct dw_pcie_ep *ep) if (!res) return -EINVAL; - ep->phys_base = res->start; - ep->addr_size = resource_size(res); + ep->range.cpu_addr = ep->range.pci_addr = res->start; + ep->range.size = resource_size(res); if (ep->ops->pre_init) ep->ops->pre_init(ep); @@ -891,7 +891,7 @@ int dw_pcie_ep_init(struct dw_pcie_ep *ep) if (ret < 0) epc->max_functions = 1; - ret = pci_epc_mem_init(epc, ep->phys_base, ep->addr_size, + ret = pci_epc_mem_init(epc, ep->range.cpu_addr, ep->range.size, ep->page_size); if (ret < 0) { dev_err(dev, "Failed to initialize address space\n"); diff --git a/drivers/pci/controller/dwc/pcie-designware.h b/drivers/pci/controller/dwc/pcie-designware.h index 347ab74ac35aa..59109a32b2afc 100644 --- a/drivers/pci/controller/dwc/pcie-designware.h +++ b/drivers/pci/controller/dwc/pcie-designware.h @@ -19,6 +19,7 @@ #include <linux/gpio/consumer.h> #include <linux/irq.h> #include <linux/msi.h> +#include <linux/of_address.h> #include <linux/pci.h> #include <linux/reset.h> @@ -409,8 +410,7 @@ struct dw_pcie_ep { struct pci_epc *epc; struct list_head func_list; const struct dw_pcie_ep_ops *ops; - phys_addr_t phys_base; - size_t addr_size; + struct of_pci_range range; size_t page_size; u8 bar_to_atu[PCI_STD_NUM_BARS]; phys_addr_t *outbound_addr; -- 2.34.1