Re: [PATCH v2 -next 05/11] PCI: brcmstb: Restore CRS in RootCtl after prstn_n

Subject: Re: [PATCH v2 -next 05/11] PCI: brcmstb: Restore CRS in RootCtl after prstn_n
From: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx>
Date: Tue, 10 Sep 2024 09:59:23 -0700
Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Rob Herring <robh@xxxxxxxxxx>, Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>, Conor Dooley <conor+dt@xxxxxxxxxx>, Jim Quinlan <jim2101024@xxxxxxxxx>, Nicolas Saenz Julienne <nsaenz@xxxxxxxxxx>, Bjorn Helgaas <bhelgaas@xxxxxxxxxx>, Lorenzo Pieralisi <lpieralisi@xxxxxxxxxx>, kw@xxxxxxxxx, Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>, Andrea della Porta <andrea.porta@xxxxxxxx>, Phil Elwell <phil@xxxxxxxxxxxxxxx>, Jonathan Bell <jonathan@xxxxxxxxxxxxxxx>
In-reply-to: <20240910151845.17308-6-svarbanov@suse.de>
References: <20240910151845.17308-1-svarbanov@suse.de> <20240910151845.17308-6-svarbanov@suse.de>
User-agent: Mozilla Thunderbird

On 9/10/24 08:18, Stanimir Varbanov wrote:

RootCtl bits might reset by perst_n during probe, re-enable
CRS SVE here in pcie_start_link.

Signed-off-by: Stanimir Varbanov <svarbanov@xxxxxxx>

This looks like a bug fix, and we should explain what is the uservisible effect of that, if any.

--
Florian

Follow-Ups:
- Re: [PATCH v2 -next 05/11] PCI: brcmstb: Restore CRS in RootCtl after prstn_n
  - From: Stanimir Varbanov

References:
- [PATCH v2 -next 00/11] Add PCIe support for bcm2712
  - From: Stanimir Varbanov
- [PATCH v2 -next 05/11] PCI: brcmstb: Restore CRS in RootCtl after prstn_n
  - From: Stanimir Varbanov