Hello, > > Change num_inbound_wins from u8 to int to correctly handle > > potential negative error codes returned by brcm_pcie_get_inbound_wins(). > > The u8 type was inappropriate for capturing the function's return value, > > which can include error codes. > > I squashed with the current code on the controller/brcmstb branch, see: > > - https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/commit/?h=controller/brcmstb&id=ae6476c6de187bea90c729e3e0188143300fa671 > > And credited you via the Co-developed-by tag such that you get credit for > fixing this issue. Thank you, by the way. > > There is no Fixes: tag as this code is not yet merged into the mainline. For the record, I would prefer if we went with Florian's first recommendation per the following message: - https://lore.kernel.org/linux-pci/159c5fcf-709d-42ba-8d45-a70b109fe261@xxxxxxxxxxxx To clearly separate errors returned from the value being updated. Albeit, this is fine too, especially as Jim expressed no opinion either way regarding his preference. Krzysztof
