On Thu, Aug 29, 2024 at 04:55:19PM +0800, WangYuli wrote: > > On 2024/8/29 16:46, Greg KH wrote: > > Please read the top of this file, there's no need to add this id to this > > file as you are only using it in one .c file. > > Thanks for review. > > More files using PCI_VENDOR_ID_PHYTIUM will appear,though maybe not in the > USB subsystem. > > These patches are on their way and I won't keep you waiting too long. When that change happens, then you can add it to the .h file. > However,if I temporarily delete this line and use a raw hexadecimal value in > xhci-pci.c,I'll need to modify xhci-pci.c again soon. Just put the define in xhci-pci.c and all will be fine. thanks, greg k-h