On Mon, Aug 26, 2024 at 03:49:12PM -0700, Jakub Kicinski wrote: > On Mon, 26 Aug 2024 16:56:36 -0400 Andy Gospodarek wrote: > > We plan to replace these calls with calls to stop and start only that > > ring via netdev_rx_queue_restart as soon as these calls all land in > > the same tree. Since this set is [presumably] coming through > > linux-pci we didn't think we could do that yet. > > > > Thoughts? > > The merge window is in 3 weeks or so, so this can wait. Are you asking for the patch for this feature to include the queue stop/start instead of this? I just checked linux-pci and it does have bnxt_queue_stop/bnxt_queue_start. > I'm worried we'll find out later that the current queue reset > implementation in bnxt turns out to be insufficient. And we'll > be stuck with yet another close/open in this driver. The queue reset _has_ to work. We will ensure that it does and fix any problems found. Note that these have been under test already internally and fixes are/will be posted to the list as they are made. Holding this patch because an API that it uses might not work seems odd.
