* Stephen Warren wrote:
> On 06/11/2012 09:05 AM, Thierry Reding wrote:
> > With the device tree support in place, probe the PCIe controller from
> > the device tree and remove the corresponding workaround in the board
> > file.
>
> > diff --git a/arch/arm/boot/dts/tegra-harmony.dts b/arch/arm/boot/dts/tegra-harmony.dts
>
> > + pci_vdd_reg: fixedregulator@0 {
>
> I think that'd usually just be "regulator@0".
>
> If you need the "@0" part to differentiate between multiple regulators,
> the node needs a reg property too:
>
> reg = <0 0>;
>
> although then I wonder about putting the regulator under the root node,
> since the address wouldn't really make sense...
Perhaps we should add a new "regulators" node under the root node to collect
this kind of regulators that don't fit anywhere else. Looking at the code,
something like this should work:
/ {
...
regulators {
compatible = "simple-bus";
#address-cells = <1>;
#size-cells = <0>;
pci_vdd_reg: regulator@0 {
reg = <0>;
};
};
};
Thierry
Attachment:
pgpw26SvAN829.pgp
Description: PGP signature
