On 06/11/2012 11:07 PM, Thierry Reding wrote: > * Stephen Warren wrote: >> On 06/11/2012 09:05 AM, Thierry Reding wrote: >>> This commit adds support for message signaled interrupts to the >>> Tegra PCIe controller. Based on code by Krishna Kishore >>> <kthota@xxxxxxxxxx>. ... >> Why allocate pcie->msi separately; why not include the fields >> directly into struct tegra_pcie_info *pcie? ... > Second, and more importantly, this will keep the size of struct > tegra_pcie_info smaller if PCI_MSI is not selected because there is > just one unused pointer instead of five unused fields. Well, you can always ifdef out the structure fields too, right? -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
