Re: Annotate PCI fixups with __devinit instead of __init

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jun 3, 2012 at 7:12 PM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote:
> On Sun, Jun 3, 2012 at 11:48 AM, Sebastian Andrzej Siewior
> <sebastian@xxxxxxxxxxxxx> wrote:
>> This patch series adds a section missmatch check to modpost which will
>> splat a warning if a PCI fixup routine (declared via
>> DECLARE_PCI_FIXUP_HEADER for instance) is defined in __init. Even if the
>> platform does not support hot-plug, one could remove the PCI bus during
>> run time (soft remove, now HW touching involved) and rediscover it again.
>> The rediscover process will call the PCI-fixups again.
>> This is patch #1. After posting it Bjorn ask for fixing the noisy warnings
>> and this is done by patch #2 to #9.
>
> These all look good to me.
>
> There's not a real dependency between #1 and the rest of them, so I
> propose that I feed #2-9 through the PCI tree and whoever normally
> handles modpost can take #1.

I put all these, including #1, in my "next" branch, which should
appear in v3.6.  If somebody wants to push the modpost change
separately, I'll remove it, but since nobody objected or stepped up to
claim it, I just kept them all together.

Thanks for doing this work!

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux