On Thu, Aug 22, 2024 at 03:47:37PM +0200, Philipp Stanner wrote: > pcim_iomap_regions() and pcim_iomap_table() have been deprecated by > the PCI subsystem in commit e354bb84a4c1 ("PCI: Deprecate > pcim_iomap_table(), pcim_iomap_regions_request_all()"). > > Replace these functions with the function pcim_iomap_region(). ... > - err = pcim_iomap_regions(pdev, 1 << PCI_PTP_BAR_NO, pci_name(pdev)); > - if (err) > + clock->reg_base = pcim_iomap_region(pdev, PCI_PTP_BAR_NO, pci_name(pdev)); > + if (IS_ERR(clock->reg_base)) { > + err = PTR_ERR(clock->reg_base); > goto error_free; > - > - clock->reg_base = pcim_iomap_table(pdev)[PCI_PTP_BAR_NO]; > + } Perhaps clock->reg_base = pcim_iomap_region(pdev, PCI_PTP_BAR_NO, pci_name(pdev)); err = PTR_ERR_OR_ZERO(clock->reg_base); if (err) goto error_free; This will make your patch smaller and neater. P.S. Do you use --histogram diff algo when preparing patches? -- With Best Regards, Andy Shevchenko