On Mon, Jun 11, 2012 at 10:43 AM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote: > On Fri, Jun 8, 2012 at 12:01 AM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote: >> On Mon, May 28, 2012 at 12:33 AM, Jiang Liu <jiang.liu@xxxxxxxxxx> wrote: >>> Changeset "9080648 PCI: acpiphp: remove all functions in slot, >>> even without ACPI _EJx" introduces pci_bus_sem into the acpiphp >>> driver, but pci_bus_sem hasn't been exported to modules yet. >>> So export symbol pci_bus_sem to modules, otherwise the acpiphp >>> driver can't be built as module any more. >>> >>> Signed-off-by: Yijing Wang <wangyijing@xxxxxxxxxx> >>> Signed-off-by: Jiang Liu <liuj97@xxxxxxxxx> >>> --- >>> drivers/pci/search.c | 2 ++ >>> 1 files changed, 2 insertions(+), 0 deletions(-) >>> >>> diff --git a/drivers/pci/search.c b/drivers/pci/search.c >>> index 9d75dc8..e0c7a22 100644 >>> --- a/drivers/pci/search.c >>> +++ b/drivers/pci/search.c >>> @@ -15,6 +15,8 @@ >>> #include "pci.h" >>> >>> DECLARE_RWSEM(pci_bus_sem); >>> +EXPORT_SYMBOL(pci_bus_sem); >>> + >>> /* >>> * find the upstream PCIe-to-PCI bridge of a PCI device >>> * if the device is PCIE, return NULL >> >> Bjorn, >> >> can you please fold this one into >> >> 9080648: >> PCI: acpiphp: remove all functions in slot, even without ACPI _EJx >> >> that commit now is in pci/for-3.6 > > Yes, I'll fix this. If you don't object, I'll make it > EXPORT_SYMBOL_GPL(). I think we'll have more changes in the bus > scan/remove paths, and it's possible we'll be able to un-export this > in the future. yes, it should be EXPORT_SYMBOL_GPL. I updated that in attachment. Thanks Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html