On Tue, 20 Aug 2024 09:02:20 -0600 Keith Busch <kbusch@xxxxxxxxxx> wrote: > On Thu, Aug 15, 2024 at 03:17:17PM +0100, Jonathan Cameron wrote: > > On Mon, 22 Jul 2024 08:19:29 -0700 > > Keith Busch <kbusch@xxxxxxxx> wrote: > > > > > From: Keith Busch <kbusch@xxxxxxxxxx> > > > > > > Use the atomic ADDED flag to safely ensure concurrent callers can't > > > attempt to stop the device multiple times. > > > > Maybe mention what concurrent paths exist where this might happen. > > I think everyone calling this is holding the pci_rescan_remove_lock, so > it shouldn't be possible today. This series aims to remove that lock > though, so this is more of a prep patch for that. But also, the flag is > already an atomic type, so using those properties makes sense on its own > too. Ok. Perhaps mention that it's cleanup / a prep patch rather than a fix. The current text scared me a bit ;) Jonathan
