On Mon, Aug 19, 2024 at 11:03:18AM +0200, Stefan Eichenberger wrote: > From: Stefan Eichenberger <stefan.eichenberger@xxxxxxxxxxx> > > After enabling the ref clock, we should wait for the clock to stabilize. > To eliminate the need for code duplication in the future, move the > usleep to the enable_ref_clk function. Logically, it's better wait in imx6_pcie_clk_enable(). But not sure why it can reduce duplication. Frank > > Signed-off-by: Stefan Eichenberger <stefan.eichenberger@xxxxxxxxxxx> > --- > drivers/pci/controller/dwc/pci-imx6.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c > index fda704d82431f..f17561791e35a 100644 > --- a/drivers/pci/controller/dwc/pci-imx6.c > +++ b/drivers/pci/controller/dwc/pci-imx6.c > @@ -632,6 +632,9 @@ static int imx6_pcie_enable_ref_clk(struct imx6_pcie *imx6_pcie) > break; > } > > + /* allow the clocks to stabilize */ > + usleep_range(200, 500); > + > return ret; > } > > @@ -672,8 +675,6 @@ static int imx6_pcie_clk_enable(struct imx6_pcie *imx6_pcie) > goto err_ref_clk; > } > > - /* allow the clocks to stabilize */ > - usleep_range(200, 500); > return 0; > > err_ref_clk: > -- > 2.43.0 >
