Hi Manivannan, Thanks for your review comments. On Thu, 15 Aug 2024 at 21:41, Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> wrote: > > On Tue, Jun 25, 2024 at 04:10:32PM +0530, Anand Moon wrote: > > Refactor the clock handling in the Rockchip PCIe driver, > > introducing a more robust and efficient method for enabling and > > disabling clocks using clk_bulk*() API. Using the clk_bulk APIs, > > the clock handling for the core clocks becomes much simpler. > > > > Why can't you just use devm_clk_bulk_get_all()? This gets rid of hardcoding the > clock names in driver. > Sure, I will update the patch. > - Mani > Thanks -Anand