On Fri, Aug 16, 2024 at 01:09:50PM -0400, Frank Li wrote: > On Fri, Aug 16, 2024 at 11:12:31AM +0530, Manivannan Sadhasivam wrote: > > On Thu, Aug 15, 2024 at 03:15:52PM -0600, Rob Herring wrote: > > > On Thu, Aug 15, 2024 at 9:53 AM Manivannan Sadhasivam > > > <manivannan.sadhasivam@xxxxxxxxxx> wrote: > > > > On Thu, Aug 08, 2024 at 12:02:17PM -0400, Frank Li wrote: > > > > > LX2160 Rev1 use mobivel PCIe controller, but Rev2 switch to designware > > > > > PCIe controller. Rev2 is mass production chip. Rev1 will not be maintained > > > > > so drop maintainer information for that. > > > > > > > > Instead of suddenly removing the code and breaking users, you can just mark the > > > > driver as 'Obsolete' in MAINTAINERS. Then after some point of time, we could > > > > hopefully remove. > > > > > > Is anyone really going to pay attention to that? It doesn't sound like > > > there's anyone to really care, and it is the company that made the h/w > > > asking to remove it. The only thing people use pre-production h/w for > > > once there's production h/w is as a dust collector. > > > > > > If anyone complains, it's simple enough to revert these patches. > > > > My comment was based on the fact that Bjorn was not comfortable in removing the > > driver [1] unless no Rev1 boards are not in use and Frank said that he was not > > sure about that [2]. > > > > But I think if Frank can atleast guarantee that the chip never made into mass > > production or shared with customers, then we can remove the driver IMO. But that > > is up to the discretion of Bjorn. > > I think Bjorn's request is impossible task. Generally chip company send > out some evaluted sample to parter, which use these sample to built up > some small quantity production. Chip company have not responsibility to > call back this samples. There are always some reasons to drop mobivel and > switch designware, it may be caused by some IP issues which can't match > mass production's requirememnt. Such informaiton already removed from > nxp.com. Only Rev2 left. If you're reasonably confident that nobody will notice the removal of support for Rev1, we can include that in the commit log and just remove it. The original commit log basically said "we don't want to support Rev1" without any indication of where those parts went or whether anybody might care about them. But if Rev1 only went to partners for evaluation and we don't expect end users to have them, I think it's reasonable to say that and remove the code. Bjorn
