On Thu, Aug 15, 2024 at 03:15:52PM -0600, Rob Herring wrote: > On Thu, Aug 15, 2024 at 9:53 AM Manivannan Sadhasivam > <manivannan.sadhasivam@xxxxxxxxxx> wrote: > > > > On Thu, Aug 08, 2024 at 12:02:17PM -0400, Frank Li wrote: > > > LX2160 Rev1 use mobivel PCIe controller, but Rev2 switch to designware > > > PCIe controller. Rev2 is mass production chip. Rev1 will not be maintained > > > so drop maintainer information for that. > > > > > > > Instead of suddenly removing the code and breaking users, you can just mark the > > driver as 'Obsolete' in MAINTAINERS. Then after some point of time, we could > > hopefully remove. > > Is anyone really going to pay attention to that? It doesn't sound like > there's anyone to really care, and it is the company that made the h/w > asking to remove it. The only thing people use pre-production h/w for > once there's production h/w is as a dust collector. > > If anyone complains, it's simple enough to revert these patches. > My comment was based on the fact that Bjorn was not comfortable in removing the driver [1] unless no Rev1 boards are not in use and Frank said that he was not sure about that [2]. But I think if Frank can atleast guarantee that the chip never made into mass production or shared with customers, then we can remove the driver IMO. But that is up to the discretion of Bjorn. - Mani [1] https://lore.kernel.org/linux-pci/20240808172644.GA151261@bhelgaas/ [2] https://lore.kernel.org/linux-pci/ZrUJngABI8v3pN6o@lizhi-Precision-Tower-5810/ - Mani -- மணிவண்ணன் சதாசிவம்
