Re: [PATCH v5 3/3] PCI/NPEM: Add _DSM PCIe SSD status LED management

Subject: Re: [PATCH v5 3/3] PCI/NPEM: Add _DSM PCIe SSD status LED management
From: Christoph Hellwig <hch@xxxxxx>
Date: Tue, 13 Aug 2024 17:13:15 +0200
Cc: linux-pci@xxxxxxxxxxxxxxx, Lukas Wunner <lukas@xxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>, Stuart Hayes <stuart.w.hayes@xxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Bjorn Helgaas <bhelgaas@xxxxxxxxxx>, Dan Williams <dan.j.williams@xxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Keith Busch <kbusch@xxxxxxxxxx>, Marek Behun <marek.behun@xxxxxx>, Pavel Machek <pavel@xxxxxx>, Randy Dunlap <rdunlap@xxxxxxxxxxxxx>, Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
In-reply-to: <20240813113024.17938-4-mariusz.tkaczyk@linux.intel.com>
References: <20240813113024.17938-1-mariusz.tkaczyk@linux.intel.com> <20240813113024.17938-4-mariusz.tkaczyk@linux.intel.com>
User-agent: Mutt/1.5.17 (2007-11-01)

Still looks good to me (despite the still pointless __packed):

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

References:
- [PATCH v5 0/3] PCIe Enclosure LED Management
  - From: Mariusz Tkaczyk
- [PATCH v5 3/3] PCI/NPEM: Add _DSM PCIe SSD status LED management
  - From: Mariusz Tkaczyk