On Sat, Aug 03, 2024 at 07:28:52PM +0800, Jisheng Zhang wrote: > commit 815953dc2011ad7a34de355dfa703dcef1085219 upstream > > If a host that uses the IP's integrated MSI Receiver lost power > during suspend, we call dw_pcie_setup_rc() to reinit the RC. But > dw_pcie_setup_rc() always sets pp->irq_mask[ctrl] to ~0, so the mask > register is always set as 0xffffffff incorrectly, thus the MSI can't > work after resume. > > Fix this issue by moving pp->irq_mask[ctrl] initialization to > dw_pcie_host_init() so we can correctly set the mask reg during both > boot and resume. > > Tested-by: Richard Zhu <hongxing.zhu@xxxxxxx> > Link: https://lore.kernel.org/r/20211226074019.2556-1-jszhang@xxxxxxxxxx > Signed-off-by: Jisheng Zhang <jszhang@xxxxxxxxxx> > Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx> > Signed-off-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> > --- > drivers/pci/controller/dwc/pcie-designware-host.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > Now queued up, thanks. greg k-h