On Mon, 12 Feb 2024, Ilpo Järvinen wrote: > > Only return successful completion status from `pcie_failed_link_retrain' > > if retraining has actually been done, preventing excessive delays from > > being triggered at call sites in a hope that communication will finally > > be established with the downstream device where in fact nothing has been > > done about the link in question that would justify such a hope. > > > > Fixes: a89c82249c37 ("PCI: Work around PCIe link training failures") > > Reported-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx> > > Link: https://lore.kernel.org/r/aa2d1c4e-9961-d54a-00c7-ddf8e858a9b0@xxxxxxxxxxxxxxx/ > > Signed-off-by: Maciej W. Rozycki <macro@xxxxxxxxxxx> > > Cc: stable@xxxxxxxxxxxxxxx # v6.5+ > > Thanks. > > The original thread might be useful for context if somebody has to look at > this change later on from the history, so: > > Link: https://lore.kernel.org/linux-pci/20240129112710.2852-2-ilpo.jarvinen@xxxxxxxxxxxxxxx/T/#u This refers the same thread of discussion as the link already included (and also is not a permalink), so I chose not to duplicate it in v2. > Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx> Thank you (also for the other change)! New series posted: <https://patchwork.kernel.org/project/linux-pci/list/?series=878216>. Maciej