On Thu, Aug 08, 2024 at 12:26:44PM -0500, Bjorn Helgaas wrote: > On Thu, Aug 08, 2024 at 12:02:16PM -0400, Frank Li wrote: > > Only lx2160 rev1 use mobiveil PCIe controller. Rev2 switch to designware > > PCIe controller. Rev2 is mass production chip and Rev1 will be not > > supported. So drop related code. > > I'd love to drop this, but only if you're confident that no Rev 1 > controllers are in the field with people using them. The explanation > above doesn't go quite that far. It's not enough that Mobiveil > doesn't want to support Rev 1. If we know that all Rev 1 controllers > have been destroyed, that would be perfect and useful to include here. I can't guarrantee all Rev1 have been destroyed because some may left on someone's drawer or lab. How about drop all document firstly, and set kConfig bool "Freescale Layerscape Gen4 PCIe controller (DEPRECATE)" if COMPILE_TEST So layerscape gen4 will not built. Sometime later, if no one complain, we can remove all safely. Frank > > Bjorn
