On Wed, Aug 07, 2024 at 05:15:36PM -0400, Esther Shimanovich wrote: > On Wed, Aug 7, 2024 at 3:17 AM Mika Westerberg > <mika.westerberg@xxxxxxxxxxxxxxx> wrote: > > > > I suggest opening the heuristic here a bit more. > > Could you clarify what you mean by "opening the heuristic"? > What details should I remove? I mean not to remove anything but open up how we "detect" the built-in controlllers. > And add the links to > > the Microsoft firmware document somewhere. These: > > > > https://learn.microsoft.com/en-us/windows-hardware/drivers/pci/dsd-for-pcie-root-ports#mapping-native-protocols-pcie-displayport-tunneled-through-usb4-to-usb4-host-routers > > https://learn.microsoft.com/en-us/windows-hardware/drivers/pci/dsd-for-pcie-root-ports#identifying-externally-exposed-pcie-root-ports > > Is it good enough to have them in the commit message? Or should they > be linked in probe.c? IMHO they can be in the commit message.
