On Tue, Aug 06, 2024 at 05:54:15PM -0300, Guilherme Giácomo Simões wrote: > Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx> wrote: > > On Sat, 3 Aug 2024, Guilherme Giacomo Simoes wrote: > > > > > I can see that the function pci_hp_add_brigde have a int return > > > propagation. > ... > > The lack of return value checking seems to be on the list in > > pci_hp_add_bridge(). So perhaps the right course of action would be to > > handle return values correctly. > > Ok, so if the right course is for the driver to handle return value, > then this is a > task for the driver developers, because only they know what to do when > pci_hp_add_bridge() doesn't work correctly, right? pci_hp_add_bridge() is only for hotplug drivers, so the list of callers is short and completely under our control. There's plenty of opportunity for improving this. Beyond just the return value, all the callers of pci_hp_add_bridge() should be doing much of the same work that could potentially be factored out. Bjorn
