On Tue, 23 Jul 2024 15:27:12 +0200
Marek Vasut <marek.vasut+renesas@xxxxxxxxxxx> wrote:
> Use newly introduced MSI_FLAG_NO_AFFINITY, which keeps
> .irq_set_affinity unset and allows migrate_one_irq() code in
> cpuhotplug.c to exit right away, without printing "IRQ...: set
> affinity failed(-22)" warning.
>
> Remove .irq_set_affinity implementation which only return -EINVAL
> from this controller driver.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxxxx>
> ---
> Cc: "Krzysztof Wilczyński" <kw@xxxxxxxxx>
> Cc: "Pali Rohár" <pali@xxxxxxxxxx>
> Cc: "Uwe Kleine-König" <u.kleine-koenig@xxxxxxxxxxxxxx>
> Cc: Aleksandr Mishin <amishin@xxxxxxxxxx>
> Cc: Anna-Maria Behnsen <anna-maria@xxxxxxxxxxxxx>
> Cc: Anup Patel <apatel@xxxxxxxxxxxxxxxx>
> Cc: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> Cc: Broadcom internal kernel review list
> <bcm-kernel-feedback-list@xxxxxxxxxxxx> Cc: Daire McNamara
> <daire.mcnamara@xxxxxxxxxxxxx> Cc: Damien Le Moal <dlemoal@xxxxxxxxxx>
> Cc: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx>
> Cc: Hou Zhiqiang <Zhiqiang.Hou@xxxxxxx>
> Cc: Jianjun Wang <jianjun.wang@xxxxxxxxxxxx>
> Cc: Jim Quinlan <jim2101024@xxxxxxxxx>
> Cc: Jingoo Han <jingoohan1@xxxxxxxxx>
> Cc: Jisheng Zhang <Jisheng.Zhang@xxxxxxxxxxxxx>
> Cc: Jon Hunter <jonathanh@xxxxxxxxxx>
> Cc: Jonathan Derrick <jonathan.derrick@xxxxxxxxx>
> Cc: Jonathan Hunter <jonathanh@xxxxxxxxxx>
> Cc: Joyce Ooi <joyce.ooi@xxxxxxxxx>
> Cc: Karthikeyan Mitran <m.karthikeyan@xxxxxxxxxxxxxx>
> Cc: Kishon Vijay Abraham I <kishon@xxxxxxxxxx>
> Cc: Koichiro Den <den@xxxxxxxxxxxxx>
> Cc: Lorenzo Pieralisi <lpieralisi@xxxxxxxxxx>
> Cc: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
> Cc: Marc Zyngier <maz@xxxxxxxxxx>
> Cc: Michal Simek <michal.simek@xxxxxxx>
> Cc: Nicolas Saenz Julienne <nsaenz@xxxxxxxxxx>
> Cc: Niklas Cassel <cassel@xxxxxxxxxx>
> Cc: Nipun Gupta <nipun.gupta@xxxxxxx>
> Cc: Nirmal Patel <nirmal.patel@xxxxxxxxxxxxxxx>
> Cc: Rob Herring <robh@xxxxxxxxxx>
> Cc: Ryder Lee <ryder.lee@xxxxxxxxxxxx>
> Cc: Shivamurthy Shastri <shivamurthy.shastri@xxxxxxxxxxxxx>
> Cc: Siddharth Vadapalli <s-vadapalli@xxxxxx>
> Cc: Thierry Reding <thierry.reding@xxxxxxxxx>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxx>
> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Cc: linux-mediatek@xxxxxxxxxxxxxxxxxxx
> Cc: linux-pci@xxxxxxxxxxxxxxx
> Cc: linux-renesas-soc@xxxxxxxxxxxxxxx
> Cc: linux-rpi-kernel@xxxxxxxxxxxxxxxxxxx
> Cc: linux-tegra@xxxxxxxxxxxxxxx
> ---
> V4: - New patch
> ---
> drivers/pci/controller/vmd.c | 13 +------------
> 1 file changed, 1 insertion(+), 12 deletions(-)
>
> diff --git a/drivers/pci/controller/vmd.c
> b/drivers/pci/controller/vmd.c index a726de0af011f..bc849b0d9e8dc
> 100644 --- a/drivers/pci/controller/vmd.c
> +++ b/drivers/pci/controller/vmd.c
> @@ -204,22 +204,11 @@ static void vmd_irq_disable(struct irq_data
> *data) raw_spin_unlock_irqrestore(&list_lock, flags);
> }
>
> -/*
> - * XXX: Stubbed until we develop acceptable way to not create
> conflicts with
> - * other devices sharing the same vector.
> - */
> -static int vmd_irq_set_affinity(struct irq_data *data,
> - const struct cpumask *dest, bool
> force) -{
> - return -EINVAL;
> -}
> -
> static struct irq_chip vmd_msi_controller = {
> .name = "VMD-MSI",
> .irq_enable = vmd_irq_enable,
> .irq_disable = vmd_irq_disable,
> .irq_compose_msi_msg = vmd_compose_msi_msg,
> - .irq_set_affinity = vmd_irq_set_affinity,
> };
>
> static irq_hw_number_t vmd_get_hwirq(struct msi_domain_info *info,
> @@ -326,7 +315,7 @@ static struct msi_domain_ops vmd_msi_domain_ops =
> {
> static struct msi_domain_info vmd_msi_domain_info = {
> .flags = MSI_FLAG_USE_DEF_DOM_OPS |
> MSI_FLAG_USE_DEF_CHIP_OPS |
> - MSI_FLAG_PCI_MSIX,
> + MSI_FLAG_NO_AFFINITY | MSI_FLAG_PCI_MSIX,
> .ops = &vmd_msi_domain_ops,
> .chip = &vmd_msi_controller,
> };
Reviewed-by: Nirmal Patel <nirmal.patel@xxxxxxxxxxxxxxx>
Thanks.
