On Thu, Oct 19, 2023 at 11:58:29AM -0500, Bjorn Helgaas wrote: > Is it feasible to build an attribute group in pci_doe_init() and add > it to dev->groups so device_add() will automatically add them? Note that pcibios_device_add() in arch/s390/pci/pci.c does this: pdev->dev.groups = zpci_attr_groups; ... which prevents usage of pdev->dev.groups for anything else. This needs to be cleaned up first before the PCI core can allocate and fill generic attribute groups on enumeration. Thanks, Lukas