On Fri, Aug 02, 2024 at 12:44:07AM -0500, Wei Huang wrote: > > > On 7/23/24 11:48, Bjorn Helgaas wrote: > > On Wed, Jul 17, 2024 at 03:55:10PM -0500, Wei Huang wrote: > > > From: Manoj Panicker <manoj.panicker2@xxxxxxx> > > > > > > Implement TPH support in Broadcom BNXT device driver by invoking > > > pcie_tph_set_st() function when interrupt affinity is changed. > > > > *and* invoking pcie_tph_set_st() when setting up the IRQ in the first > > place, I guess? > > > > I guess this gives a significant performance benefit? The series > > includes "pci=nostmode" so the benefit can be quantified, so now I'm > > curious about what you measured :) > > Using network benchmarks, three main metrics were measured: network latency, > network bandwidth, and memory bandwidth saving. I was hoping you could share actual percentage improvements to justify the new code. If there's no improvement, obviously there would be no point in adding the code. If there's significant improvement, it will encourage using this in other drivers, which will improve the code and testing for everybody. Bjorn
