> +static enum led_brightness brightness_get(struct led_classdev *led)
> +{
> + struct npem_led *nled = container_of(led, struct npem_led, led);
> + struct npem *npem = nled->npem;
> + int ret, val = LED_OFF;
Don't use LED_OFF and LED_ON. Instead use 0 and 1. Set max_brightness to 1.
Enum led_brightness is obsolete:
/* This is obsolete/useless. We now support variable maximum brightness. */
Marek
