Re: [PATCH v3 5/7] dt-bindings: bus: Add Hyper-V VMBus cache coherency and IRQs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 7/27/2024 1:53 AM, Krzysztof Kozlowski wrote:
On 27/07/2024 00:59, Roman Kisel wrote:
Add dt-bindings for the Hyper-V VMBus DMA cache coherency
and interrupt specification.


You did not add any bindings. I don't understand this description.

My bad, extended the example for the interrupt controller node.
Will fix in the next version.

Anyway, not tested.

Understood. I didn't realize that yml goes through testing, thought it
was akin to a machine-readable portion of the documentation.

<form letter>
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.
I used the "cached" version of the get_maintainers.pl output produced for v2. The bad assumption was that adding a yml do Documentation would not affect that. Will fix, appreciate helping me so much in getting this into a good shape!


Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.

You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time.

Please kindly resend and include all necessary To/Cc entries.
</form letter>


Best regards,
Krzysztof


--
Thank you,
Roman





[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux