In subject, to match history: s|PCI/rcar-host|PCI: rcar-host| On Mon, Jul 15, 2024 at 02:19:27PM +0200, Marek Vasut wrote: > Use newly introduced MSI_FLAG_NO_AFFINITY, which keeps .irq_set_affinity unset > and allows migrate_one_irq() code in cpuhotplug.c to exit right away, without > printing "IRQ...: set affinity failed(-22)" warning. > > Remove .irq_set_affinity implementation which only return -EINVAL from this > controller driver. This would be a nice improvement; thanks for working on it. As you allude to at [1], there are many more PCI controller drivers that could benefit from similar changes. I'd like to do them all at once if possible. [1] https://lore.kernel.org/r/d5efcb28-dd5a-4b96-aabd-c73c95dff8e7@xxxxxxxxxxx > Signed-off-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxxxx> > --- > Cc: "Krzysztof Wilczyński" <kw@xxxxxxxxx> > Cc: Anna-Maria Behnsen <anna-maria@xxxxxxxxxxxxx> > Cc: Anup Patel <apatel@xxxxxxxxxxxxxxxx> > Cc: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> > Cc: Jisheng Zhang <Jisheng.Zhang@xxxxxxxxxxxxx> > Cc: Jon Hunter <jonathanh@xxxxxxxxxx> > Cc: Jonathan Hunter <jonathanh@xxxxxxxxxx> > Cc: Koichiro Den <den@xxxxxxxxxxxxx> > Cc: Lorenzo Pieralisi <lpieralisi@xxxxxxxxxx> > Cc: Marc Zyngier <maz@xxxxxxxxxx> > Cc: Nipun Gupta <nipun.gupta@xxxxxxx> > Cc: Rob Herring <robh@xxxxxxxxxx> > Cc: Shivamurthy Shastri <shivamurthy.shastri@xxxxxxxxxxxxx> > Cc: Thierry Reding <thierry.reding@xxxxxxxxx> > Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx> > Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> > Cc: linux-pci@xxxxxxxxxxxxxxx > Cc: linux-renesas-soc@xxxxxxxxxxxxxxx > Cc: linux-tegra@xxxxxxxxxxxxxxx > --- > V3: - New patch > --- > drivers/pci/controller/pcie-rcar-host.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/drivers/pci/controller/pcie-rcar-host.c b/drivers/pci/controller/pcie-rcar-host.c > index c01efc6ea64f6..3dd653f3d7841 100644 > --- a/drivers/pci/controller/pcie-rcar-host.c > +++ b/drivers/pci/controller/pcie-rcar-host.c > @@ -658,11 +658,6 @@ static void rcar_msi_irq_unmask(struct irq_data *d) > spin_unlock_irqrestore(&msi->mask_lock, flags); > } > > -static int rcar_msi_set_affinity(struct irq_data *d, const struct cpumask *mask, bool force) > -{ > - return -EINVAL; > -} > - > static void rcar_compose_msi_msg(struct irq_data *data, struct msi_msg *msg) > { > struct rcar_msi *msi = irq_data_get_irq_chip_data(data); > @@ -678,7 +673,6 @@ static struct irq_chip rcar_msi_bottom_chip = { > .irq_ack = rcar_msi_irq_ack, > .irq_mask = rcar_msi_irq_mask, > .irq_unmask = rcar_msi_irq_unmask, > - .irq_set_affinity = rcar_msi_set_affinity, > .irq_compose_msi_msg = rcar_compose_msi_msg, > }; > > @@ -725,8 +719,8 @@ static const struct irq_domain_ops rcar_msi_domain_ops = { > }; > > static struct msi_domain_info rcar_msi_info = { > - .flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS | > - MSI_FLAG_MULTI_PCI_MSI), > + .flags = MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS | > + MSI_FLAG_NO_AFFINITY | MSI_FLAG_MULTI_PCI_MSI, > .chip = &rcar_msi_top_chip, > }; > > -- > 2.43.0 >
