On Tue, Jul 16, 2024 at 8:08 PM Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> On Tue, 16 Jul 2024 at 08:23, Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
> >
> > Let's remove the public menuconfig entry for PCI pwrctl and instead
> > default the relevant symbol to 'm' only for the architectures that
> > actually need it.
>
> This feels like you should just use "select" instead.
>
> IOW, don't make PCI_PWRCTL_PWRSEQ a question at all. Instead, have the
> drivers that need it just select it automatically.
>
But this patch does it. PCI_PWRCTL_PWRSEQ becomes a hidden symbol and
the entire submenu for PCI_PWRCTL disappears. There's no question in
Kconfig anymore.
On the other hand there isn't really any driver that would require
this. It's a specific platform that needs additional handling of
resources before the PCI devices can be detected. This is why we do:
default m if ((ATH11K_PCI || ATH12K) && ARCH_QCOM)
If we selected it from the ATH1[12]K entry then we'd be building it
for many platforms that don't need it.
Bartosz
