On Tue, Jul 16, 2024 at 05:23:18PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
>
> Kconfig will ask the user twice about power sequencing: once for the QCom
> WCN power sequencing driver and then again for the PCI power control
> driver using it.
>
> Let's remove the public menuconfig entry for PCI pwrctl and instead
> default the relevant symbol to 'm' only for the architectures that
> actually need it.
>
Why can't you put it in defconfig instead?
- Mani
> Fixes: 4565d2652a37 ("PCI/pwrctl: Add PCI power control core code")
> Reported-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> Closes: https://lore.kernel.org/lkml/CAHk-=wjWc5dzcj2O1tEgNHY1rnQW63JwtuZi_vAZPqy6wqpoUQ@xxxxxxxxxxxxxx/
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> ---
> drivers/pci/pwrctl/Kconfig | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/drivers/pci/pwrctl/Kconfig b/drivers/pci/pwrctl/Kconfig
> index f1b824955d4b..b8f289e6a185 100644
> --- a/drivers/pci/pwrctl/Kconfig
> +++ b/drivers/pci/pwrctl/Kconfig
> @@ -1,17 +1,10 @@
> # SPDX-License-Identifier: GPL-2.0-only
>
> -menu "PCI Power control drivers"
> -
> config PCI_PWRCTL
> tristate
>
> config PCI_PWRCTL_PWRSEQ
> - tristate "PCI Power Control driver using the Power Sequencing subsystem"
> + tristate
> select POWER_SEQUENCING
> select PCI_PWRCTL
> default m if ((ATH11K_PCI || ATH12K) && ARCH_QCOM)
> - help
> - Enable support for the PCI power control driver for device
> - drivers using the Power Sequencing subsystem.
> -
> -endmenu
> --
> 2.43.0
>
>
--
மணிவண்ணன் சதாசிவம்
